[Buildroot] [PATCH v4 06/20] boot/ti-k3-core-secdev: new package

Sun Feb 18 13:20:44 UTC 2024

Hello Alexander,

On Sat, Feb 17, 2024 at 6:06 PM Alexander Sverdlin
<alexander.sverdlin at gmail.com> wrote:
>
> Hello Dario,
>
> On Sat, 2024-02-17 at 17:02 +0100, Dario Binacchi wrote:
> > This is a security development package containing tools for
> > High-Security(HS) TI K3 platform devices.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi at amarulasolutions.com>
>
> as I understand secdev package is not required for binman-based
> U-Boot deployments starting from v2023.10.
>
> So what is the point of introducing the package now if you update
> U-Boot to v2024.01?
>
> I belive it's as legacy as ti-k3-image-gen (which you are fixing)
> but Romain's patchset removed the package and, quite successfully,
> from the perspective of building for HS variants.

The series is a continuation of what I submitted for the first time at
the end of November when I still
didn't know that Binman made it possible to do without external tools.
I haven't removed it just to give
a complete overview of the patches available from then until now. In
the next version, I will remove them,
or perhaps, in the event that a single version with Romain's patches
is chosen, they will not be selected.

Thanks and regards,
Dario

>
> > ---
> >
> > Changes in v4:
> > - Remove the trailing '/' at the end of the url in the help of
> >   Config.in
> > - Fixed license issues
> > - Use $(BINARIES_DIR)/ti-k3-core-secdev as the directory where to
> >   install files.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi at amarulasolutions.com>
> > ---
> >  DEVELOPERS                                    |  1 +
> >  boot/Config.in                                |  1 +
> >  boot/ti-k3-core-secdev/Config.in              |  9 ++++++++
> >  boot/ti-k3-core-secdev/ti-k3-core-secdev.hash |  3 +++
> >  boot/ti-k3-core-secdev/ti-k3-core-secdev.mk   | 22 +++++++++++++++++++
> >  5 files changed, 36 insertions(+)
> >  create mode 100644 boot/ti-k3-core-secdev/Config.in
> >  create mode 100644 boot/ti-k3-core-secdev/ti-k3-core-secdev.hash
> >  create mode 100644 boot/ti-k3-core-secdev/ti-k3-core-secdev.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 0d12c3abcb11..33d99ab2440f 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -753,6 +753,7 @@ F:        package/xinetd/
> >  N:   Dario Binacchi <dario.binacchi at amarulasolutions.com>
> >  F:   board/bsh/
> >  F:   board/stmicroelectronics/stm32f769-disco/
> > +F:   boot/ti-k3-core-secdev/
> >  F:   configs/imx8mn_bsh_smm_s2_defconfig
> >  F:   configs/imx8mn_bsh_smm_s2_pro_defconfig
> >  F:   configs/stm32f769_disco_sd_defconfig
> > diff --git a/boot/Config.in b/boot/Config.in
> > index e5fdf7ad439e..18a7d268f95a 100644
> > --- a/boot/Config.in
> > +++ b/boot/Config.in
> > @@ -20,6 +20,7 @@ source "boot/s500-bootloader/Config.in"
> >  source "boot/shim/Config.in"
> >  source "boot/syslinux/Config.in"
> >  source "boot/ti-k3-boot-firmware/Config.in"
> > +source "boot/ti-k3-core-secdev/Config.in"
> >  source "boot/ti-k3-image-gen/Config.in"
> >  source "boot/ti-k3-r5-loader/Config.in"
> >  source "boot/uboot/Config.in"
> > diff --git a/boot/ti-k3-core-secdev/Config.in b/boot/ti-k3-core-secdev/Config.in
> > new file mode 100644
> > index 000000000000..f7b4e2962042
> > --- /dev/null
> > +++ b/boot/ti-k3-core-secdev/Config.in
> > @@ -0,0 +1,9 @@
> > +config BR2_TARGET_TI_K3_CORE_SECDEV
> > +     bool "ti-k3-core-secdev"
> > +     depends on BR2_aarch64
> > +     help
> > +       This package downloads and installs development tools for
> > +       High-Security(HS) TI K3 platforms (which include AM62x,
> > +       AM64x, AM65x and more).
> > +
> > +       https://git.ti.com/cgit/security-development-tools/core-secdev-k3
> > diff --git a/boot/ti-k3-core-secdev/ti-k3-core-secdev.hash b/boot/ti-k3-core-secdev/ti-k3-core-secdev.hash
> > new file mode 100644
> > index 000000000000..e3074a398d62
> > --- /dev/null
> > +++ b/boot/ti-k3-core-secdev/ti-k3-core-secdev.hash
> > @@ -0,0 +1,3 @@
> > +# Locally calculated
> > +sha256  b6d3bca0d561d055c6869c5564b06f2fb1b9f67e4ef180c2baf8a14a6a6afa06  core-secdev-k3-08.06.00.007.tar.xz
> > +sha256  3e5cf4f5ab9f0333f46cd68fabede3f21e55de1a9e3c6ad673f241f4514d8369  manifest/k3-secdev-0.2-manifest.html
> > diff --git a/boot/ti-k3-core-secdev/ti-k3-core-secdev.mk b/boot/ti-k3-core-secdev/ti-k3-core-secdev.mk
> > new file mode 100644
> > index 000000000000..f7655a0fefc8
> > --- /dev/null
> > +++ b/boot/ti-k3-core-secdev/ti-k3-core-secdev.mk
> > @@ -0,0 +1,22 @@
> > +################################################################################
> > +#
> > +# ti-k3-core-secdev
> > +#
> > +################################################################################
> > +
> > +TI_K3_CORE_SECDEV_VERSION = 08.06.00.007
> > +TI_K3_CORE_SECDEV_SITE = https://git.ti.com/cgit/security-development-tools/core-secdev-k3/snapshot
> > +TI_K3_CORE_SECDEV_SOURCE = core-secdev-k3-$(TI_K3_CORE_SECDEV_VERSION).tar.xz
> > +TI_K3_CORE_SECDEV_INSTALL_IMAGES = YES
> > +TI_K3_CORE_SECDEV_LICENSE = BSD-3-Clause
> > +TI_K3_CORE_SECDEV_LICENSE_FILES = manifest/k3-secdev-0.2-manifest.html
> > +
> > +TI_K3_CORE_SECDEV_INSTALL_DIR = $(BINARIES_DIR)/ti-k3-core-secdev
> > +
> > +define TI_K3_CORE_SECDEV_INSTALL_IMAGES_CMDS
> > +     mkdir -p $(TI_K3_CORE_SECDEV_INSTALL_DIR)
> > +     cp -dpfr $(@D)/keys $(TI_K3_CORE_SECDEV_INSTALL_DIR)/
> > +     cp -dpfr $(@D)/scripts $(TI_K3_CORE_SECDEV_INSTALL_DIR)/
> > +endef
> > +
> > +$(eval $(generic-package))
>
> --
> Alexander Sverdlin.
>

-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi at amarulasolutions.com

__________________________________

Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info at amarulasolutions.com

www.amarulasolutions.com