[Buildroot] [PATCH] package/nfs-utils: only install fsidd binary and unit file with enabled nfsd

[Giulio Benetti]

Hi Jan,

thank you for the contribution,

On 28/02/24 19:14, Jan Čermák wrote:
> Unit file for the FSID daemon depends on the nfs-server.service, which is
> removed without BR2_PACKAGE_NFS_UTILS_RPC_NFSD enabled. Also don't install
> the fsidd service binary without nfsd enabled.

regarding the commit log(I'm not that good at it but I give a try) what
about:
```
FSID daemon and its systemd unit file both depend on
BR2_PACKAGE_NFS_UTILS_RPC_NFSD at the moment they are installed in any
case. So let's remove them both when BR2_PACKAGE_NFS_UTILS_RPC_NFSD is
disabled.
```

> 
> Signed-off-by: Jan Čermák <sairon at sairon.cz>

For the rest it looks good to me, I've build tested it and it works
as expected so:
Reviewed-by: Giulio Benetti <giulio.benetti at benettiengineering.com>

Can you please send a V2 with improved commit log?

Thank you
Best regards
-- 
Giulio Benetti
CEO&CTO at Benetti Engineering sas

> ---
>   package/nfs-utils/nfs-utils.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index 4f2b41c782..b757e3e51d 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -42,7 +42,8 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPCDEBUG) += usr/sbin/rpcdebug
>   NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_LOCKD) += usr/sbin/rpc.lockd
>   NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
>   NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
> -	usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
> +	usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service \
> +	usr/sbin/fsidd usr/lib/systemd/system/fsidd.service
>   
>   ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
>   NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41