[Buildroot] [git commit branch/2023.11.x] package/petitboot: fix ordering of comments and sub-options

Peter Korsgaard peter at korsgaard.com
Fri Mar 1 08:38:06 UTC 2024


commit: https://git.buildroot.net/buildroot/commit/?id=c4bfb4d799d25b523c2dfa7ac2f9e7fd8487f206
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2023.11.x

Currently, the comment about availability is between the package main
symbol and its suboptions, breaking the threading in menuconfig.

Invert the order, and move the comment last. Also enclose the suboptions
between an if-block, as it is more customary.

Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
(cherry picked from commit 06dcbdf8ad3d55b92df4bc3ded82c08e21cbb60e)
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
 package/petitboot/Config.in | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/package/petitboot/Config.in b/package/petitboot/Config.in
index 93ed3642c3..f931ab91cd 100644
--- a/package/petitboot/Config.in
+++ b/package/petitboot/Config.in
@@ -19,17 +19,20 @@ config BR2_PACKAGE_PETITBOOT
 
 	  http://www.kernel.org/pub/linux/kernel/people/geoff/petitboot/petitboot.html
 
-comment "petitboot needs a toolchain w/ wchar, dynamic library, threads, udev /dev management"
-	depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS
-	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
-		!BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_PACKAGE_HAS_UDEV
+if BR2_PACKAGE_PETITBOOT
 
 config BR2_PACKAGE_PETITBOOT_GETTY_PORT
 	string "TTY port(s)"
 	default "console"
-	depends on BR2_PACKAGE_PETITBOOT
 	help
 	  Specify a space-separated list of ports to run the petitboot
 	  UI on. Wildcards are allowed. Example: "hvc* ttys0 ttyS*"
+
+endif # BR2_PACKAGE_PETITBOOT
+
+comment "petitboot needs a toolchain w/ wchar, dynamic library, threads, udev /dev management"
+	depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_PACKAGE_HAS_UDEV



More information about the buildroot mailing list