[Buildroot] [PATCH 2/2] package/zic: enable installation on target
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Tue Mar 26 14:44:34 UTC 2024
Hello Christian,
On Wed, 28 Feb 2024 15:56:41 +0100
Christian Hitz via buildroot <buildroot at buildroot.org> wrote:
> From: Christian Hitz <christian.hitz at bbv.ch>
>
> Signed-off-by: Christian Hitz <christian.hitz at bbv.ch>
Thanks, but for a patch like this, we definitely need a non-empty
commit log. Why do you need zic on the target, what is the use-case?
> diff --git a/package/zic/Config.in b/package/zic/Config.in
> new file mode 100644
> index 0000000000..11a8c99a66
> --- /dev/null
> +++ b/package/zic/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_ZIC
> + bool "zic"
> + help
No dependency on toolchain-specific features? Did you test this package
with ./utils/test-pkg ?
> diff --git a/package/zic/zic.mk b/package/zic/zic.mk
> index a915f6d256..12bb9e9943 100644
> --- a/package/zic/zic.mk
> +++ b/package/zic/zic.mk
> @@ -10,6 +10,19 @@ ZIC_SITE = https://www.iana.org/time-zones/repository/releases
> ZIC_STRIP_COMPONENTS = 0
> ZIC_LICENSE = Public domain
> ZIC_LICENSE_FILES = LICENSE
> +ZIC_INSTALL_STAGING = YES
> +
> +define ZIC_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" -C $(@D) zic
Can we use $(TARGET_CONFIGURE_OPTS) instead of CC="$(TARGET_CC)" ?
> +define ZIC_INSTALL_STAGING_CMDS
> + $(INSTALL) -D -m 644 $(@D)/tzfile.h $(TARGET_DIR)/usr/include/tzfile.h
So just the header file is needed, no library is installed?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list