[Buildroot] [PATCH v1 1/3] package/go-bootstrap-stage2: bump version to go1.19.13

[Christian Stewart]

Hi Thomas,

On Tue, May 14, 2024 at 4:39 AM Christian Stewart <christian at aperture.us> wrote:
> On Tue, May 14, 2024, 1:23 AM Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:
>>
>> I don't think it's this patch causing the issue, but we have a Go build
>> failure in our Gitlab CI:
>>
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/6833307823
>>
>> Could you have a look?
>
> This looks like we need to pass -buildvcs=false to Go. I'll have a look at submitting a patch for this.

I found this commit in Go which fixed & added a test to ensure that
-buildvcs=false is set when GOROOT_BOOTSTRAP is set (which it was in
the failing job).

commit 42a46206b97ca7cf4246d3c1230a70cf42ad5bb0
Author: Bryan C. Mills <bcmills at google.com>
Date:   Fri Sep 9 17:29:12 2022 -0400

    cmd/go: omit VCS stamping during bootstrap

    cmd/dist can't easily hard-code -buildvcs=false because not all
    versions of cmd/go supported for bootstrapping recognize that flag.

    However, we don't want to stamp the bootstrap binaries: the stamping
    is redundant with the VERSION file writted during bootstrapping (which
    is why it is normally omitted for standard-library packages and
    commands), and it may also interfere with building the Go repo from a
    source tarball or zip file.

    Fixes #54852.

    Change-Id: If223f094af137c4c202d6bf622619bd2da397ec4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/432435

See: https://github.com/golang/go/commit/42a46206b97ca7cf4246d3c1230a70cf42ad5bb0

However it seems that bootstrap step is failing due to -buildvcs=false
not being set.

I will try to debug further. This could be a Go regression.

Best regards,
Christian Stewart