[Buildroot] [PATCH v2 2/3] package/libtpms: add host package
Yann E. MORIN
yann.morin.1998 at free.fr
Fri May 17 18:44:32 UTC 2024
Jarkko, All,
On 2024-05-17 20:31 +0300, Jarkko Sakkinen spake thusly:
> Libtpms is a library that targets the integration of TPM functionality
> into hypervisors, primarily into Qemu. Libtpms provides a very narrow
> public API for this purpose so that integration is possible. Only the
> minimum of necessary APIs are made publicly available.
>
> Signed-off-by: Jarkko Sakkinen <jarkko at kernel.org>
> ---
> v2:
> - Use host packages in package/libtpms/Config.in.
> - Select BR2_HOST_PACKAGE_LIBOPENSSL.
s/HOST_PACKAGE/PACKAGE_HOST/
However [0]...
[--SNIP--]
> diff --git a/package/libtpms/Config.in b/package/libtpms/Config.in
> new file mode 100644
> index 0000000000..9308458248
> --- /dev/null
> +++ b/package/libtpms/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_HOST_PACKAGE_LIBTPMS
s/HOST_PACKAGE/PACKAGE_HOST/
> + bool "libtpms"
> + select BR2_HOST_PACKAGE_LIBTOOL
[0]... here you select libtool instead of openssl.
And we can't select libopenssl; instead we select openssl:
$ git grep 'select BR2_PACKAGE_LIBOPENSSL\>'
[nada, naught, zilch]
$ git grep 'select BR2_PACKAGE_OPENSSL\>'
[156 results]
And anyway, in this case again there is no need for a Kconfig xymbo, as
libtpms only provides a library, so there is only the need for
libtpms.mk (and the hash file too).
[--SNIP--]
> diff --git a/package/libtpms/libtpms.mk b/package/libtpms/libtpms.mk
> new file mode 100644
> index 0000000000..c588b2892c
> --- /dev/null
> +++ b/package/libtpms/libtpms.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# libtpms
> +#
> +################################################################################
> +
> +LIBTPMS_VERSION = 0.9.6
> +LIBTPMS_SITE = $(call github,stefanberger,libtpms,v$(LIBTPMS_VERSION))
> +LIBTPMS_LICENSE = BSD-4-Clause
> +LIBTPMS_LICENSE_FILES = LICENSE
> +LIBTPMS_INSTALL_STAGING = YES
> +LIBTPMS_AUTORECONF = YES
Sorry, I missed that in my previous review, but we usually add a little
comment why autoreconf is needed:
# Straight from the git repository
LIBTPMS_AUTORECONF = YES
Regards,
Yann E. MORIN.
> +HOST_LIBTPMS_DEPENDENCIES = host-libtool host-pkgconf host-libopenssl
> +HOST_LIBTPMS_CONF_OPTS = --with-openssl -with-tpm2
> +
> +$(eval $(host-autotools-package))
> --
> 2.45.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list